Re: [PATCH v6 0/4] yank: Add chardev tests and fixes

[Lukas Straub]

On Mon, 29 Mar 2021 22:19:17 +0400
Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

> Hi Lukas
> 
> On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub <lukasstraub2@web.de> wrote:
> 
> > Hello Everyone,
> > These patches increase test coverage for yank, add tests and fix bugs and
> > crashes in yank in combination with chardev-change.
> > Please Review.
> >
> > Regards,
> > Lukas Straub
> >
> > Changes:
> > -v6:
> >  -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
> >   server socket so new clients get accept()'ed properly
> >  
> 
> I can't see the change, patchew neither:
> cover.1616794852.git.lukasstraub2@web.de/diff/cover.1617035720.git.lukasstraub2@web.de/">https://patchew.org/QEMU/cover.1616794852.git.lukasstraub2@web.de/diff/cover.1617035720.git.lukasstraub2@web.de/

Oh, I forgot to git add.

> btw, could you also fix the checkpatch style issue?

Okay.

Regards,
Lukas Straub

> thanks
> 
> >
> > -v5:
> >  -test: fix memory leak
> >
> > -v4:
> >  -test: fix CharChangeTestConfig structs on stack going out of scope
> >  -test: move after bugfixes
> >
> > -v3:
> >  -Base on <cover.1616521341.git.lukasstraub2@web.de>
> >   ([PATCH 0/2] yank: Always link full yank code)
> >  -Drop patch 1 (tests: Use the normal yank code instead of stubs in
> > relevant tests)
> >
> > -v2:
> >  -test: add license
> >  -test: factorize testcases to a single function
> >  -test: test chardev_change with initialization of new chardev failing
> >  -fix chardev_change with initialization of new chardev failing
> >  -add reviewed-by and tested-by tags
> >
> > Based-on: <cover.1616521341.git.lukasstraub2@web.de>
> > ([PATCH 0/2] yank: Always link full yank code)
> >
> >
> > Lukas Straub (4):
> >   chardev/char.c: Move object_property_try_add_child out of chardev_new
> >   chardev/char.c: Always pass id to chardev_new
> >   chardev: Fix yank with the chardev-change case
> >   tests: Add tests for yank with the chardev-change case
> >
> >  MAINTAINERS            |   1 +
> >  chardev/char-socket.c  |  20 ++++-
> >  chardev/char.c         |  77 ++++++++++------
> >  include/chardev/char.h |   3 +
> >  tests/unit/meson.build |   3 +-
> >  tests/unit/test-yank.c | 200 +++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 275 insertions(+), 29 deletions(-)
> >  create mode 100644 tests/unit/test-yank.c
> >
> > --
> > 2.30.2
> >  
> 
> 



--

pgplOTGPclC6F.pgp
Description: OpenPGP digital signature