On Tue, 30 Mar 2021 at 09:29, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Mon, Mar 29, 2021 at 9:54 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>> aarch64 CI machine, which has python 3.8.5 and sphinx-build 1.8.5.
>> My guess is that it might be the sphinx-build version here. I vaguely
>> recall that Sphinx is kind of picky about exceptions within the conf
>> file but that there was a change in what it allowed at some point.
>> It's possible we just can't do much with the old versions.
>
>
> How do you run the build? Running make from an existing configured or build state? If so, I have seen sphinx errors that don't stop the build (and actually building the docs without sphinx-rtd). I don't know why this happens, "regenerate"/reconfigure errors should stop the build.
On that machine, yes, it's an incremental build.
Could you check if --enable-docs was enabled? It turns out I wasn't always checking things properly, and it works as expected for me. Without the rtd theme installed and:
- Without --enable-docs,
./docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx 'sphinx_rtd_theme' HTML theme was not found.
On incremental build, extra warnings and the build continues, disabling docs as necessary.
- With --enable-docs,
../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx 'sphinx_rtd_theme' HTML theme was not found.
../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx and the readthedoc theme
A full log can be found at /home/elmarco/src/qemu/build/meson-logs/meson-log.txt
ERROR: meson setup failed
On incremental build, it correctly stops:
../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx 'sphinx_rtd_theme' HTML theme was not found.
../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx and the readthedoc theme
A full log can be found at /home/elmarco/src/qemu/build/meson-logs/meson-log.txt
ninja: error: FAILED: build.ninja
/usr/bin/meson --internal regenerate /home/elmarco/src/qemu /home/elmarco/src/qemu/build --backend ninja
rebuilding 'build.ninja': subcommand failed
make: *** [Makefile:152: run-ninja] Error 1