[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL for-6.0 1/6] block/vdi: When writing new bmap entry fails, don't l
From: |
Stefan Hajnoczi |
Subject: |
[PULL for-6.0 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer |
Date: |
Wed, 31 Mar 2021 10:50:54 +0100 |
From: David Edmondson <david.edmondson@oracle.com>
If a new bitmap entry is allocated, requiring the entire block to be
written, avoiding leaking the buffer allocated for the block should
the write fail.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Max Reitz <mreitz@redhat.com>
Message-id: 20210325112941.365238-2-pbonzini@redhat.com
Message-Id: <20210309144015.557477-2-david.edmondson@oracle.com>
Acked-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 5627e7d764..2a6dc26124 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -690,6 +690,7 @@ nonallocating_write:
logout("finished data write\n");
if (ret < 0) {
+ g_free(block);
return ret;
}
--
2.30.2
- [PULL for-6.0 0/6] Block patches, Stefan Hajnoczi, 2021/03/31
- [PULL for-6.0 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer,
Stefan Hajnoczi <=
- [PULL for-6.0 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader, Stefan Hajnoczi, 2021/03/31
- [PULL for-6.0 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once, Stefan Hajnoczi, 2021/03/31
- [PULL for-6.0 4/6] coroutine-lock: Reimplement CoRwlock to fix downgrade bug, Stefan Hajnoczi, 2021/03/31
- [PULL for-6.0 5/6] test-coroutine: Add rwlock upgrade test, Stefan Hajnoczi, 2021/03/31
- [PULL for-6.0 6/6] test-coroutine: Add rwlock downgrade test, Stefan Hajnoczi, 2021/03/31