Re: [PATCH] nsis: Install *.elf images

[Stefan Weil]

Am 06.04.21 um 11:04 schrieb Bin Meng:

> On Fri, Mar 26, 2021 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > As of today, the QEMU Windows installer does not include the
> > following two RISC-V BIOS images:
> >
> > - opensbi-riscv64-generic-fw_dynamic.elf
> > - opensbi-riscv32-generic-fw_dynamic.elf
> >
> > Update the installer script to include them.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > ---
> > Based on:
> > https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
> >
> > The above commit does not land on QEMU master. I am not sure what
> > the process is, sending it here for comments.
> >
> >   qemu.nsi | 2 ++
> >   1 file changed, 2 insertions(+)
> Ping?


Reviewed-by: Stefan Weil <sw@weilnetz.de>

This is a small uncritical fix which can be merged via QEMU trivial.

As Philippe already mentioned, a more advanced solution would only 
install the required binaries, but typically the NSIS installer is built 
with all system emulations, so it requires all available blobs. 
Thererfore the current solution is fine for now.

Regards,

Stefan