qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v12 41/65] tests: restrict TCG-only arm-cpu-features tests to T


From: Claudio Fontana
Subject: Re: [RFC v12 41/65] tests: restrict TCG-only arm-cpu-features tests to TCG builds
Date: Thu, 8 Apr 2021 15:30:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0

On 3/28/21 7:23 PM, Richard Henderson wrote:
> On 3/26/21 1:36 PM, Claudio Fontana wrote:
>> sve_tests_sve_max_vq_8,
>> sve_tests_sve_off,
>> test_query_cpu_model_expansion
> 
> The final two confused me before I realized there are separate tests for kvm. 
> I think we should rename them to *_tcg, so that it's clearer next to the kvm 
> brothers.
> 
>> +#ifndef CONFIG_TCG
> 
> Also, tcg_enabled() again.
> 
> 
> r~
> 

I don't think we have access to that from here, right?

If we use tcg_enabled(), this would be replaced with tcg_allowed, that is not 
set for qtest, and we end up skipping all the time?

I think even the presence of CONFIG_TCG is a necessary workaround that Paolo 
has set in place, but had to be explicitly coded in.

Or did I remember wrong?

Thanks,

Claudio





reply via email to

[Prev in Thread] Current Thread [Next in Thread]