[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/5] channel-socket: Only set CLOEXEC if we have space fo
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [RFC PATCH 1/5] channel-socket: Only set CLOEXEC if we have space for fds |
|
Date: |
Fri, 9 Apr 2021 10:03:28 +0100 |
|
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Thu, Apr 08, 2021 at 08:11:55PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> MSG_CMSG_CLOEXEC cleans up received fd's; it's really only for Unix
> sockets, but currently we enable it for everything; some socket types
> (IP_MPTCP) don't like this.
>
> Only enable it when we're giving the recvmsg room to receive fd's
> anyway.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> io/channel-socket.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [RFC PATCH 0/5] mptcp support, Dr. David Alan Gilbert (git), 2021/04/08
- [RFC PATCH 1/5] channel-socket: Only set CLOEXEC if we have space for fds, Dr. David Alan Gilbert (git), 2021/04/08
- Re: [RFC PATCH 1/5] channel-socket: Only set CLOEXEC if we have space for fds,
Daniel P . Berrangé <=
- [RFC PATCH 3/5] migration: Add cleanup hook for inwards migration, Dr. David Alan Gilbert (git), 2021/04/08
- [RFC PATCH 4/5] migration/socket: Close the listener at the end, Dr. David Alan Gilbert (git), 2021/04/08
- [RFC PATCH 5/5] sockets: Support multipath TCP, Dr. David Alan Gilbert (git), 2021/04/08
- [RFC PATCH 2/5] io/net-listener: Call the notifier during finalize, Dr. David Alan Gilbert (git), 2021/04/08