Re: gitlab-ci check-dco test

[Daniel P . Berrangé]

On Sat, Apr 10, 2021 at 11:03:19AM +0200, Philippe Mathieu-Daudé wrote:
> On 4/10/21 4:58 AM, Richard Henderson wrote:
> > On development branches, it's not uncommon to push
> > temporary --fixup patches, and normally one doesn't
> > sign those.  But then of course one get hate-mail
> > from the gitlab-ci job about the failing test.
> > 
> > Is there a way to make it fatal on staging, but
> > merely a warning on other branches (a-la checkpatch)?
> 
> To only run check-dco on branch /staging on any namespace:
> 
> -- >8 --
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3480d79db3a..f0d21da57f0 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -781,9 +781,9 @@ check-dco:
>    needs:
>      job: amd64-centos8-container
>    script: .gitlab-ci.d/check-dco.py
> -  except:
> +  only:
>      variables:
> -      - $CI_PROJECT_NAMESPACE == 'qemu-project' && $CI_COMMIT_BRANCH ==
> 'master'
> +      - $CI_COMMIT_BRANCH == 'staging'
>    variables:
>      GIT_DEPTH: 1000

Definitely don't want that - it skips the DCO check entirely on all
branches except 'staging'. We want contributors to see the missing
SoB on any of their branches *before* they send them to qemu-devel
at all.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|