[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 0/5] mptcp support
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [RFC PATCH 0/5] mptcp support |
Date: |
Mon, 12 Apr 2021 15:46:21 +0100 |
User-agent: |
Mutt/2.0.6 (2021-03-06) |
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Fri, Apr 09, 2021 at 10:34:30AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > I had a quick go at trying NBD as well, but I think it needs
> > > some work with the parsing of NBD addresses.
> >
> > In theory this is applicable to anywhere that we use sockets.
> > Anywhere that is configured with the QAPI SocketAddress /
> > SocketAddressLegacy type will get it for free AFAICT.
>
> The caveat is any servers which share the problem of prematurely
> closing the listener socket that you fixed here for migration.
Right, this varies depending on the server semantics; migration is only
expecting a single connection so shut it immediately; nbd is already
wired to expect multiple connections.
Dave
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [RFC PATCH 4/5] migration/socket: Close the listener at the end, (continued)