[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C"
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C" |
Date: |
Thu, 15 Apr 2021 10:20:57 +0100 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Wed, Apr 14, 2021 at 07:50:41PM +0100, Peter Maydell wrote:
> On Wed, 14 Apr 2021 at 18:26, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Tue, Apr 13, 2021 at 06:08:49PM +0200, Paolo Bonzini wrote:
> > > #ifdef _WIN32
> > > #include "sysemu/os-win32.h"
> >
> > This and os-posix.h both include other system headers. We don't currently
> > have problem, so this is ok as the minimal fix for 6.0, but long term we
> > need more work on this header to further narrow the extern {} block.
>
> Maybe we should just move all the system header includes out of
> both os-posix.h and os-win32.h ? We already have one header file
> we've treated that way (sys/wait.h).
>
> Alternatively we could leave os-win32.h and os-posix.h outside
> osdep.h's extern block, and require that they both use an
> extern block themselves for their declarations.
I'd be inclined towards the latter as I tihnk its reasonable for
os-win32/posix.h to want to include system headers.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Paolo Bonzini, 2021/04/13
- [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers, Paolo Bonzini, 2021/04/13
- [PULL v2 3/3] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code, Paolo Bonzini, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, no-reply, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Peter Maydell, 2021/04/13
- Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3, Peter Maydell, 2021/04/14