qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.0? 1/6] osdep: include glib-compat.h before other QEMU


From: Richard Henderson
Subject: Re: [PATCH for-6.0? 1/6] osdep: include glib-compat.h before other QEMU headers
Date: Fri, 16 Apr 2021 10:16:39 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/16/21 6:55 AM, Peter Maydell wrote:
From: Paolo Bonzini<pbonzini@redhat.com>

glib-compat.h is sort of like a system header, and it needs to include
system headers (glib.h) that may dislike being included under
'extern "C"'.  Move it right after all system headers and before
all other QEMU headers.

Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
Reviewed-by: Daniel P. Berrangé<berrange@redhat.com>
Reviewed-by: Peter Maydell<peter.maydell@linaro.org>
[PMM: Added comment about why glib-compat.h is special]
Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/qemu/osdep.h | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]