Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

[Wainer dos Santos Moschetta]

On 4/16/21 2:46 PM, Philippe Mathieu-Daudé wrote:
> On 4/16/21 5:43 PM, Cleber Rosa wrote:
> > On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote:
> > > On 4/15/21 11:51 PM, Cleber Rosa wrote:
> > > > These tests' setUp do not do anything beyong what their base class do.
> > > > And while they do decorate the setUp() we can decorate the classes
> > > > instead, so no functionality is lost here.
> > > This is what I did first when adding this test, but it was not working,
> > > so I had to duplicate it to each method. Did something change so now
> > > this is possible?
> > It did, but quite a while ago:
> >
> >    
> > https://avocado-framework.readthedocs.io/en/87.0/releases/76_0.html#users-test-writers
> OK, the test is older. Do you mind adding a comment?
>
> "Since Avocado 76.0 we can decorate setUp() directly, ..."

Ditto.

Also you may want to adjust VirtiofsSubmountsTest.setUp() in 
tests/acceptance/virtiofs_submounts.py as well.

- Wainer

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> > It could have been updated much earlier, but, better late than never.
> Sure :)
>
> Thanks,
>
> Phil.