Re: [PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function

[Richard Henderson]

On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:
> +static void fpu_dump_fpr(fpr_t *fpr, FILE *f, bool is_fpu64)

If you're going to use bool here,

>   static void fpu_dump_state(CPUMIPSState *env, FILE *f, int flags)
>   {
>       int i;
>       int is_fpu64 = !!(env->hflags & MIPS_HFLAG_F64);

... you should probably use it here too.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~