[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/12] target/hexagon: introduce new helper functions
From: |
Alessandro Di Federico |
Subject: |
Re: [PATCH v4 06/12] target/hexagon: introduce new helper functions |
Date: |
Tue, 20 Apr 2021 08:39:38 +0200 |
On Mon, 19 Apr 2021 15:00:17 +0000
Taylor Simpson <tsimpson@quicinc.com> wrote:
> Once this patch series is merged, many load/store instructions will
> have manual overrides. I can easily provide overrides for the
> remainder. Then, we could skip them in the idef-parser. At a
> minimum, you should skip the ones that are part of that series
> - circular addressing
> https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01355.html
> - bit reverse addressing
> https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01354.html
> - load and unpack bytes
> https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01353.html
>
> - load into shifted register
> https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01359.html
>
> Alessandro, what do you think?
If, for an instruction, all idef-parse does is calling an helper, yeah,
it makes sense to exclude them.
I'll look into this again once your patchset is in.
--
Alessandro Di Federico
rev.ng
[PATCH v4 08/12] target/hexagon: prepare input for the idef-parser, Alessandro Di Federico, 2021/04/15
[PATCH v4 10/12] target/hexagon: import parser for idef-parser, Alessandro Di Federico, 2021/04/15