[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_ver
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests |
Date: |
Thu, 22 Apr 2021 08:21:48 -0400 |
On Thu, Apr 08, 2021 at 04:52:37PM -0300, Wainer dos Santos Moschetta wrote:
> Some test cases on x86_cpu_model_versions.py are corner cases because they
> need to pass extra options to the -cpu argument. Once the avocado_qemu
> framework will set -cpu automatically, the value should be reset. This changed
> those tests so to call set_vm_arg() to overwrite the -cpu value.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> tests/acceptance/x86_cpu_model_versions.py | 40 +++++++++++++++++-----
> 1 file changed, 32 insertions(+), 8 deletions(-)
>
This LGTM, but, since it depends on the previous patch, I'll hold my
R-b/T-b until I can test with the modified behavior.
Thanks!
- Cleber.
signature.asc
Description: PGP signature
- [PATCH v2 5/7] python/qemu: Add args property to the QEMUMachine class, (continued)
- [PATCH v2 5/7] python/qemu: Add args property to the QEMUMachine class, Wainer dos Santos Moschetta, 2021/04/08
- [PATCH v2 2/7] tests/acceptance: Fix mismatch on cpu tagged tests, Wainer dos Santos Moschetta, 2021/04/08
- [PATCH v2 3/7] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests, Wainer dos Santos Moschetta, 2021/04/08
- [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests, Wainer dos Santos Moschetta, 2021/04/08
- Re: [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests,
Cleber Rosa <=
- [PATCH v2 1/7] tests/acceptance: Automatic set -cpu to the test vm, Wainer dos Santos Moschetta, 2021/04/08
- Re: [PATCH v2 0/7] tests/acceptance: Handle tests with "cpu" tag, Cleber Rosa, 2021/04/22