Re: [PATCH 2/4] linux-user/arm: Do not emulate fpa11 in thumb mode

[Peter Maydell]

On Fri, 23 Apr 2021 at 17:58, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> These antiquated instructions are arm-mode only.
>
> Buglink: https://bugs.launchpad.net/bugs/1925512
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/arm/cpu_loop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c
> index 106909c7d8..e2a1496b9f 100644
> --- a/linux-user/arm/cpu_loop.c
> +++ b/linux-user/arm/cpu_loop.c
> @@ -347,7 +347,7 @@ void cpu_loop(CPUARMState *env)
>                      goto excp_debug;
>                  }
>
> -                if (emulate_arm_fpa11(env, opcode)) {
> +                if (!env->thumb && emulate_arm_fpa11(env, opcode)) {
>                      break;
>                  }

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM