Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructio

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructio

From:	Richard Henderson
Subject:	Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions
Date:	Sat, 24 Apr 2021 10:08:11 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/23/21 8:34 PM, Alistair Francis wrote:

--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -74,8 +74,6 @@ static inline bool has_ext(DisasContext *ctx, uint32_t ext)

#ifdef TARGET_RISCV32

  # define is_32bit(ctx)  true
-#elif defined(CONFIG_USER_ONLY)
-# define is_32bit(ctx)  false
  #else
  static inline bool is_32bit(DisasContext *ctx)
  {


Rebase error?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 00/10] RISC-V: Steps towards running 32-bit guests on, Alistair Francis, 2021/04/23
- [PATCH v3 01/10] target/riscv: Remove the hardcoded RVXLEN macro, Alistair Francis, 2021/04/23
- [PATCH v3 02/10] target/riscv: Remove the hardcoded SSTATUS_SD macro, Alistair Francis, 2021/04/23
- [PATCH v3 03/10] target/riscv: Remove the hardcoded HGATP_MODE macro, Alistair Francis, 2021/04/23
- [PATCH v3 04/10] target/riscv: Remove the hardcoded MSTATUS_SD macro, Alistair Francis, 2021/04/23
- [PATCH v3 05/10] target/riscv: Remove the hardcoded SATP_MODE macro, Alistair Francis, 2021/04/23
- [PATCH v3 06/10] target/riscv: Remove the unused HSTATUS_WPRI macro, Alistair Francis, 2021/04/23
- [PATCH v3 07/10] target/riscv: Remove an unused CASE_OP_32_64 macro, Alistair Francis, 2021/04/23
- [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions, Alistair Francis, 2021/04/23
  - Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions, Richard Henderson <=
    - Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions, Alistair Francis, 2021/04/25
    - Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions, Richard Henderson, 2021/04/25
    - Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions, Alistair Francis, 2021/04/26
- [PATCH v3 09/10] target/riscv: Consolidate RV32/64 16-bit instructions, Alistair Francis, 2021/04/23
- [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment, Alistair Francis, 2021/04/23
  - Re: [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment, Richard Henderson, 2021/04/24
    - Re: [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment, Alistair Francis, 2021/04/25
- Re: [PATCH v3 00/10] RISC-V: Steps towards running 32-bit guests on, Alistair Francis, 2021/04/25

Prev by Date: Re: [PATCH v2 00/48] bsd-user style and reorg patches
Next by Date: Re: [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment
Previous by thread: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions
Next by thread: Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions
Index(es):
- Date
- Thread