[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 09/12] target/hexagon: import lexer for idef-parser
From: |
Taylor Simpson |
Subject: |
RE: [PATCH v3 09/12] target/hexagon: import lexer for idef-parser |
Date: |
Tue, 27 Apr 2021 02:11:58 +0000 |
> -----Original Message-----
> From: Alessandro Di Federico <ale.qemu@rev.ng>
> Sent: Tuesday, March 30, 2021 9:38 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>; Brian Cain
> <bcain@quicinc.com>; babush@rev.ng; nizzo@rev.ng; philmd@redhat.com;
> richard.henderson@linaro.org; Alessandro Di Federico <ale@rev.ng>
> Subject: [PATCH v3 09/12] target/hexagon: import lexer for idef-parser
>
> +"fLSBNEW(P"{LOWER_PRE}"N)" { yylval->rvalue.type = PREDICATE;
> + yylval->rvalue.pre.id = yytext[9];
> + yylval->rvalue.bit_width = 32;
> + yylval->rvalue.is_dotnew = true;
> + return PRE; }
> +"fLSBNEW0" { yylval->rvalue.type = PREDICATE;
> + yylval->rvalue.pre.id = '0';
> + yylval->rvalue.bit_width = 32;
> + yylval->rvalue.is_dotnew = true;
> + return PRE; }
> +"fLSBNEW1" { yylval->rvalue.type = PREDICATE;
> + yylval->rvalue.pre.id = '1';
> + yylval->rvalue.bit_width = 32;
> + yylval->rvalue.is_dotnew = true;
> + return PRE; }
> +"fLSBNEW1NOT" { yylval->rvalue.type = PREDICATE;
> + yylval->rvalue.pre.id = '1';
> + yylval->rvalue.bit_width = 32;
> + yylval->rvalue.is_dotnew = true;
> + return PRE; }
These represent the least significant bit of the operand. Perhaps you should
set the bit_width to 1? Or do tcg_gen_andi_tl(..., 1)?
Thanks,
Taylor
- RE: [PATCH v3 09/12] target/hexagon: import lexer for idef-parser,
Taylor Simpson <=