[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine |
Date: |
Tue, 27 Apr 2021 14:54:30 +0100 |
On Tue, Apr 27, 2021 at 03:27:40PM +0200, Philippe Mathieu-Daudé wrote:
> 2/ There is no Kconfig dependency IDE_PIIX -> ISA_BUS, apparently
> we need it.
Adding an ISA_BUS Kconfig dependency won't solve the problem since the
qemu-system-x86_64 binary is built with many machine types. Most of then
include ISA_BUS so the IDE_PIIX device will be linked in and available
when -M x-remote is used. The crash will still occur.
> Anyhow I think it would be easier to manage the ISA code if the bus
> were created explicitly, not under our feet. I have a WIP series
> doing that, but it isn't easy (as with all very old QEMU code/devices).
I suggest fixing this at the qdev level. Make piix3-ide have a
sub-device that inherits from ISA_DEVICE so it can only be instantiated
when there's an ISA bus.
Stefan
signature.asc
Description: PGP signature
- [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Thomas Huth, 2021/04/16
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Philippe Mathieu-Daudé, 2021/04/27
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine,
Stefan Hajnoczi <=
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, John Snow, 2021/04/27
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Philippe Mathieu-Daudé, 2021/04/27
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, John Snow, 2021/04/27
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/29
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/28
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, John Snow, 2021/04/27