[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/8] hw/block/fdc: Replace disabled fprintf() by trace event
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 1/8] hw/block/fdc: Replace disabled fprintf() by trace event |
Date: |
Wed, 28 Apr 2021 14:50:57 +0200 |
Reviewed-by: John Snow <jsnow@redhat.com>
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/block/fdc.c | 7 +------
hw/block/trace-events | 1 +
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index a825c2acbae..1d3a0473678 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d)
static void fdctrl_handle_tc(void *opaque, int irq, int level)
{
- //FDCtrl *s = opaque;
-
- if (level) {
- // XXX
- FLOPPY_DPRINTF("TC pulsed\n");
- }
+ trace_fdctrl_tc_pulse(level);
}
/* Change IRQ state */
diff --git a/hw/block/trace-events b/hw/block/trace-events
index fa12e3a67a7..306989c193c 100644
--- a/hw/block/trace-events
+++ b/hw/block/trace-events
@@ -3,6 +3,7 @@
# fdc.c
fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x"
fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x"
+fdctrl_tc_pulse(int level) "TC pulse: %u"
# pflash_cfi01.c
# pflash_cfi02.c
--
2.26.3
- [PATCH v2 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers, Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 1/8] hw/block/fdc: Replace disabled fprintf() by trace event,
Philippe Mathieu-Daudé <=
- [PATCH v2 2/8] hw/block/fdc: Declare shared prototypes in fdc-internal.h, Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 3/8] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c, Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 4/8] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c, Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 5/8] hw/block/fdc: Add sysbus_fdc_init_drives() method, Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 6/8] hw/sparc/sun4m: Inline sun4m_fdctrl_init(), Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 8/8] hw/mips/jazz: Inline fdctrl_init_sysbus(), Philippe Mathieu-Daudé, 2021/04/28
- [PATCH v2 7/8] hw/block/fdc-sysbus: Add 'dma-channel' property, Philippe Mathieu-Daudé, 2021/04/28