Re: [PATCH] tools/meson.build: Error on enabling virtiofsd and have_system is false

[Connor Kuehl]

On 4/28/21 8:35 AM, Mahmoud Mandour wrote:
> Previously, on configuring with --enable-virtiofsd and specifying
> a target list that does not contain a full-system emulation target,
> a spurious error message is emitted. This patch introduces a
> meaningful error message for such case.
> 
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
> ---
>  tools/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/meson.build b/tools/meson.build
> index 3e5a0abfa2..f6a4ced2f4 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -5,7 +5,9 @@ have_virtiofsd = (targetos == 'linux' and
>      'CONFIG_VHOST_USER' in config_host)
>  
>  if get_option('virtiofsd').enabled()
> -  if not have_virtiofsd
> +  if not have_system
> +    error('virtiofsd requires full-system emulation target(s)')

I am not entirely sure if this is true. The error message before this
patch is applied is:

        ../tools/meson.build:12:6: ERROR: Problem encountered: virtiofsd
        requires libcap-ng-devel and seccomp-devel

>From what I know about virtiofsd, I know it definitely depends on those
two things.

Is it possible that the error here is that the top-level meson.build is
not properly collecting the seccomp and libcap-ng dependencies if the
configure invocation doesn't require a system emulation target?

Thanks,

Connor

> +  elif not have_virtiofsd
>      if targetos != 'linux'
>        error('virtiofsd requires Linux')
>      elif not seccomp.found() or not libcap_ng.found()
>