[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/10] util: vfio-helpers: Factor out and fix processing o
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 01/10] util: vfio-helpers: Factor out and fix processing of existing ram blocks |
Date: |
Thu, 29 Apr 2021 15:13:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/29/21 1:26 PM, David Hildenbrand wrote:
> Factor it out into common code when a new notifier is registered, just
> as done with the memory region notifier. This keeps logic about how to
> process existing ram blocks at a central place.
>
> Just like when adding a new ram block, we have to register the max_length.
> Ram blocks are only "fake resized". All memory (max_length) is mapped.
>
> Print the warning from inside qemu_vfio_ram_block_added().
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/core/numa.c | 14 ++++++++++++++
> include/exec/cpu-common.h | 1 +
> softmmu/physmem.c | 5 +++++
> util/vfio-helpers.c | 29 ++++++++---------------------
> 4 files changed, 28 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 00/10] numa/exec/migration: Fix resizing RAM blocks while migrating, David Hildenbrand, 2021/04/29
- [PATCH v5 01/10] util: vfio-helpers: Factor out and fix processing of existing ram blocks, David Hildenbrand, 2021/04/29
- Re: [PATCH v5 01/10] util: vfio-helpers: Factor out and fix processing of existing ram blocks,
Philippe Mathieu-Daudé <=
- [PATCH v5 02/10] numa: Teach ram block notifiers about resizeable ram blocks, David Hildenbrand, 2021/04/29
- [PATCH v5 03/10] numa: Make all callbacks of ram block notifiers optional, David Hildenbrand, 2021/04/29
- [PATCH v5 04/10] migration/ram: Handle RAM block resizes during precopy, David Hildenbrand, 2021/04/29
- [PATCH v5 05/10] exec: Relax range check in ram_block_discard_range(), David Hildenbrand, 2021/04/29
- [PATCH v5 06/10] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init(), David Hildenbrand, 2021/04/29
- [PATCH v5 07/10] migration/ram: Simplify host page handling in ram_load_postcopy(), David Hildenbrand, 2021/04/29
- [PATCH v5 08/10] migration/ram: Handle RAM block resizes during postcopy, David Hildenbrand, 2021/04/29
- [PATCH v5 09/10] migration/multifd: Print used_length of memory block, David Hildenbrand, 2021/04/29
- [PATCH v5 10/10] migration/ram: Use offset_in_ramblock() in range checks, David Hildenbrand, 2021/04/29