Re: [PATCH v1] scripts: fix generation update-binfmts templates

[Laurent Vivier]

Le 23/03/2021 à 13:34, Silvano Cirujano Cuesta a écrit :
> This patch fixes the update-binfmts templates being used in the script
> scripts/qemu-binfmt-conf.sh when the option --debian is used.
> 
> Fixed issues are:
> - Typo in flag 'credentials' (previously 'credential').
> - Missing flags 'preserve' and 'fix_binary'.
> 
> Reference: 
> https://manpages.debian.org/buster/binfmt-support/update-binfmts.8.en.html#FORMAT_FILES
> 
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
>  scripts/qemu-binfmt-conf.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 573b5dc6ac..7de996d536 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -294,7 +294,9 @@ package qemu-$cpu
>  interpreter $qemu
>  magic $magic
>  mask $mask
> -credential $CREDENTIAL
> +credentials $CREDENTIAL
> +preserve $PRESERVE_ARG0
> +fix_binary $PERSISTENT
>  EOF
>  }
>  
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>