[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/5] bsd-user: style tweak: return is not a function, eliminate ()
From: |
Warner Losh |
Subject: |
[PULL 3/5] bsd-user: style tweak: return is not a function, eliminate () |
Date: |
Fri, 30 Apr 2021 11:27:44 -0600 |
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/bsdload.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c
index 546946b91d..fd14ffa4cd 100644
--- a/bsd-user/bsdload.c
+++ b/bsd-user/bsdload.c
@@ -28,7 +28,7 @@ static int count(char **vec)
vec++;
}
- return(i);
+ return i;
}
static int prepare_binprm(struct linux_binprm *bprm)
@@ -38,15 +38,15 @@ static int prepare_binprm(struct linux_binprm *bprm)
int retval;
if (fstat(bprm->fd, &st) < 0) {
- return(-errno);
+ return -errno;
}
mode = st.st_mode;
if (!S_ISREG(mode)) { /* Must be regular file */
- return(-EACCES);
+ return -EACCES;
}
if (!(mode & 0111)) { /* Must have at least one execute bit set */
- return(-EACCES);
+ return -EACCES;
}
bprm->e_uid = geteuid();
@@ -75,10 +75,9 @@ static int prepare_binprm(struct linux_binprm *bprm)
if (retval < 0) {
perror("prepare_binprm");
exit(-1);
- /* return(-errno); */
}
else {
- return(retval);
+ return retval;
}
}
@@ -169,5 +168,5 @@ int loader_exec(const char *filename, char **argv, char
**envp,
for (i = 0 ; i < MAX_ARG_PAGES ; i++) {
g_free(bprm.page[i]);
}
- return(retval);
+ return retval;
}
--
2.22.1
- [PULL 0/5] bsd-user: minor cleanup patches, Warner Losh, 2021/04/30
- [PULL 3/5] bsd-user: style tweak: return is not a function, eliminate (),
Warner Losh <=
- [PULL 1/5] bsd-user: whitespace changes, Warner Losh, 2021/04/30
- [PULL 2/5] bsd-user: style tweak: keyword space (, Warner Losh, 2021/04/30
- [PULL 4/5] bsd-user: put back a break; that had gone missing..., Warner Losh, 2021/04/30
- [PULL 5/5] bsd-user: style tweak: Put {} around all if/else/for statements, Warner Losh, 2021/04/30