[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static
From: |
Bruno Piazera Larsen |
Subject: |
Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static |
Date: |
Mon, 3 May 2021 08:28:34 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 30/04/2021 22:05, Richard Henderson
wrote:
On
4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
+++ b/target/ppc/spr_tcg.c.inc
@@ -17,6 +17,8 @@
* License along with this library; if not, see
<http://www.gnu.org/licenses/>.
*/
+#include "spr_tcg.h"
...
+++ b/target/ppc/translate_init.c.inc
@@ -42,6 +42,7 @@
#include "fpu/softfloat.h"
#include "qapi/qapi-commands-machine-target.h"
+#include "spr_tcg.h"
/* #define PPC_DEBUG_SPR */
/* #define USE_APPLE_GDB */
Including this header twice, in files that are themselves both
included in translate.c, is sketchy. You really shouldn't add the
one to translate_init.c.inc until patch 7, when it becomes the
standalone cpu_init.c.
Good point, it might be a better idea if we end up going with
spr_tcg.c.inc.
Otherwise,
Reviewed-by: Richard Henderson
<richard.henderson@linaro.org>
Note for future cleanup: Make spr_tcg.c be standalone as well.
Just need to move a few declarations to a translate.h.
it's not that easy, unfortunately. The readers and writers use a lot
of global variables declared in translate.c, so we'd need to create
getters and setters, or some better solution, before doing that.
r~
--
Bruno Piazera Larsen
Departamento Computação Embarcada
Analista de Software Trainee
- Re: [PATCH v3 4/7] target/ppc: turned SPR R/W callbacks not static,
Bruno Piazera Larsen <=