[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/7] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref
From: |
Li Qiang |
Subject: |
[PATCH 5/7] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref' |
Date: |
Tue, 4 May 2021 21:58:22 -0700 |
The 'res->iov' will be leaked if the guest trigger following sequences:
virgl_cmd_create_resource_2d
virgl_resource_attach_backing
virgl_cmd_resource_unref
This patch fixes this.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
contrib/vhost-user-gpu/virgl.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
index 6a332d601f..c669d73a1d 100644
--- a/contrib/vhost-user-gpu/virgl.c
+++ b/contrib/vhost-user-gpu/virgl.c
@@ -108,9 +108,16 @@ virgl_cmd_resource_unref(VuGpu *g,
struct virtio_gpu_ctrl_command *cmd)
{
struct virtio_gpu_resource_unref unref;
+ struct iovec *res_iovs = NULL;
+ int num_iovs = 0;
VUGPU_FILL_CMD(unref);
+ virgl_renderer_resource_detach_iov(unref.resource_id,
+ &res_iovs,
+ &num_iovs);
+ g_free(res_iovs);
+
virgl_renderer_resource_unref(unref.resource_id);
}
--
2.25.1
- Re: [PATCH 2/7] vhost-user-gpu: fix resource leak in 'vg_resource_create_2d', (continued)
[PATCH 7/7] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset', Li Qiang, 2021/05/05
[PATCH 5/7] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref',
Li Qiang <=
[PATCH 3/7] vhost-user-gpu: fix memory leak in vg_resource_attach_backing, Li Qiang, 2021/05/05
[PATCH 6/7] vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing', Li Qiang, 2021/05/05