[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] block: use GDateTime for formatting timestamp when dumping s
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 2/7] block: use GDateTime for formatting timestamp when dumping snapshot info |
Date: |
Wed, 5 May 2021 11:36:57 +0100 |
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
block/qapi.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index 943e7b15ad..06851fb469 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -663,10 +663,8 @@ BlockStatsList *qmp_query_blockstats(bool has_query_nodes,
void bdrv_snapshot_dump(QEMUSnapshotInfo *sn)
{
- char date_buf[128], clock_buf[128];
+ char clock_buf[128];
char icount_buf[128] = {0};
- struct tm tm;
- time_t ti;
int64_t secs;
char *sizing = NULL;
@@ -674,10 +672,9 @@ void bdrv_snapshot_dump(QEMUSnapshotInfo *sn)
qemu_printf("%-10s%-17s%8s%20s%13s%11s",
"ID", "TAG", "VM SIZE", "DATE", "VM CLOCK", "ICOUNT");
} else {
- ti = sn->date_sec;
- localtime_r(&ti, &tm);
- strftime(date_buf, sizeof(date_buf),
- "%Y-%m-%d %H:%M:%S", &tm);
+ g_autoptr(GDateTime) date =
g_date_time_new_from_unix_local(sn->date_sec);
+ g_autofree char *date_buf = g_date_time_format(date, "%Y-%m-%d
%H:%M:%S");
+
secs = sn->vm_clock_nsec / 1000000000;
snprintf(clock_buf, sizeof(clock_buf),
"%02d:%02d:%02d.%03d",
--
2.31.1
- [PATCH 0/7] replace all use of strftime() with g_date_time_format(), Daniel P . Berrangé, 2021/05/05
- [PATCH 1/7] migration: use GDateTime for formatting timestamp in snapshot names, Daniel P . Berrangé, 2021/05/05
- [PATCH 2/7] block: use GDateTime for formatting timestamp when dumping snapshot info,
Daniel P . Berrangé <=
- [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages, Daniel P . Berrangé, 2021/05/05
- [PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for objects, Daniel P . Berrangé, 2021/05/05
- [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers, Daniel P . Berrangé, 2021/05/05
- [PATCH 6/7] linux-user: use GDateTime for formatting timestamp for core file, Daniel P . Berrangé, 2021/05/05
- [PATCH 7/7] virtiofsd: use GDateTime for formatting timestamp for debug messages, Daniel P . Berrangé, 2021/05/05