[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages |
Date: |
Wed, 5 May 2021 11:36:58 +0100 |
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/net/rocker/rocker.h | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
index 941c932265..412fa44d01 100644
--- a/hw/net/rocker/rocker.h
+++ b/hw/net/rocker/rocker.h
@@ -25,14 +25,9 @@
#if defined(DEBUG_ROCKER)
# define DPRINTF(fmt, ...) \
do { \
- struct timeval tv; \
- char timestr[64]; \
- time_t now; \
- gettimeofday(&tv, NULL); \
- now = tv.tv_sec; \
- strftime(timestr, sizeof(timestr), "%T", localtime(&now)); \
- fprintf(stderr, "%s.%06ld ", timestr, tv.tv_usec); \
- fprintf(stderr, "ROCKER: " fmt, ## __VA_ARGS__); \
+ g_autoptr(GDateTime) now = g_date_time_new_now_local(); \
+ g_autofree char *nowstr = g_date_time_format(now, "%T.%f");\
+ fprintf(stderr, "%s ROCKER: " fmt, nowstr, ## __VA_ARGS__);\
} while (0)
#else
static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
--
2.31.1
- [PATCH 0/7] replace all use of strftime() with g_date_time_format(), Daniel P . Berrangé, 2021/05/05
- [PATCH 1/7] migration: use GDateTime for formatting timestamp in snapshot names, Daniel P . Berrangé, 2021/05/05
- [PATCH 2/7] block: use GDateTime for formatting timestamp when dumping snapshot info, Daniel P . Berrangé, 2021/05/05
- [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages,
Daniel P . Berrangé <=
- [PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for objects, Daniel P . Berrangé, 2021/05/05
- [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers, Daniel P . Berrangé, 2021/05/05
- [PATCH 6/7] linux-user: use GDateTime for formatting timestamp for core file, Daniel P . Berrangé, 2021/05/05
- [PATCH 7/7] virtiofsd: use GDateTime for formatting timestamp for debug messages, Daniel P . Berrangé, 2021/05/05