qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/23] hw/usb/hcd-ohci: Use definition to avoid dynamic stack


From: Richard Henderson
Subject: Re: [PATCH 14/23] hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
Date: Fri, 7 May 2021 09:39:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 5/5/21 2:10 PM, Philippe Mathieu-Daudé wrote:
The compiler isn't clever enough to figure 'width' is a constant,
so help it by using a definitions instead.

Signed-off-by: Philippe Mathieu-Daudé<philmd@redhat.com>
---
  hw/usb/hcd-ohci.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

Same comment about the commit message.  Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]