[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers |
Date: |
Tue, 11 May 2021 05:34:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Hi John,
This series is fully reviewed; can it go via your block tree?
On 4/28/21 2:50 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> The floppy disc controllers pulls in irrelevant devices (sysbus in
> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>
> This series clean that by extracting each device in its own file,
> adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
>
> Since v1:
> - added missing "hw/block/block.h" header (jsnow)
> - inlined hardware specific calls (Mark)
> - added R-b/A-b tags
> Philippe Mathieu-Daudé (8):
> hw/block/fdc: Replace disabled fprintf() by trace event
> hw/block/fdc: Declare shared prototypes in fdc-internal.h
> hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
> hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c
> hw/block/fdc: Add sysbus_fdc_init_drives() method
> hw/sparc/sun4m: Inline sun4m_fdctrl_init()
> hw/block/fdc-sysbus: Add 'dma-channel' property
> hw/mips/jazz: Inline fdctrl_init_sysbus()