[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2 |
Date: |
Tue, 11 May 2021 15:32:21 +0100 |
User-agent: |
Mutt/2.0.6 (2021-03-06) |
On Tue, May 11, 2021 at 04:18:54PM +0200, Thomas Huth wrote:
> On 11/05/2021 15.26, Daniel P. Berrangé wrote:
> > Several distros have been dropped since the last time we bumped the
> > minimum required CLang version.
> [...]
> > -# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
> > -# error You need at least Clang v3.4 to compile QEMU
> > +# if __clang_major__ < 7 || (__clang_major__ == 7 && __clang_minor__ < 0)
>
> __clang_minor__ < 0 is very unlikely ... I think you could drop the part
> after the "||".
True, though it might be desirable to keep it as a placeholder for when
we next bump the min version and have a non-zero minor digit.
>
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 11/12] configure: bump min required GCC to 6.3.0, (continued)
- [PATCH 11/12] configure: bump min required GCC to 6.3.0, Daniel P . Berrangé, 2021/05/11
- [PATCH 10/12] bump min required glib version to 2.50, Daniel P . Berrangé, 2021/05/11
- [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2, Daniel P . Berrangé, 2021/05/11
- Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2, Thomas Huth, 2021/05/11
- Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2,
Daniel P . Berrangé <=
- Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2, Willian Rampazzo, 2021/05/11
- Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2, Richard Henderson, 2021/05/11
- Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2, Philippe Mathieu-Daudé, 2021/05/12
- non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Thomas Huth, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Willian Rampazzo, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Thomas Huth, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Willian Rampazzo, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Thomas Huth, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Daniel P . Berrangé, 2021/05/12
- Re: non-x86 runners in the Gitlab-CI (was: Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2), Philippe Mathieu-Daudé, 2021/05/12