[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] net/tap: minor fixes to interaction with the bridge help
|
From: |
Connor Kuehl |
|
Subject: |
Re: [PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper |
|
Date: |
Tue, 11 May 2021 13:54:18 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> QEMU fails to report a good error message if the bridge helper exits
> with success code, but forgets to pass back an FD.
>
> There is also a minor portability problem impacting FreeBSD/NetBSD
> dealing with cmsg initialization.
>
> Daniel P. Berrangé (2):
> net/tap: fix FreeBSD portability problem receiving TAP FD
> net/tap: fix error reporting when bridge helper forgets to send an FD
>
> net/tap.c | 34 +++++++++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 11 deletions(-)
>
Just a minor question on patch 2.
Otherwise, for the series:
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>