Re: [PATCH 12/12] configure: bump min required CLang to 7.0.0 / XCode 10.2

[Philippe Mathieu-Daudé]

On 5/11/21 3:26 PM, Daniel P. Berrangé wrote:
> Several distros have been dropped since the last time we bumped the
> minimum required CLang version.
> 
> Per repology, currently shipping versions are:
> 
>              RHEL-8: 10.0.1
>      Debian Stretch: 7.0.1
>       Debian Buster: 7.0.1
>  openSUSE Leap 15.2: 9.0.1
>    Ubuntu LTS 18.04: 10.0.0
>    Ubuntu LTS 20.04: 11.0.0
>          FreeBSD 12: 8.0.1
>           Fedora 33: 11.0.0
>           Fedora 34: 11.1.0
> 
> With this list Debian Stretch is the constraint at 7.0.1
> 
> An LLVM version of 7.0.1 corresponds to macOS XCode version of 10.2
> which dates from March 2019.

But we still rely on Travis-CI (Ubuntu Bionic 18.04 LTS)
for non-x86 targets until we have figured out who is willing
to share/maintain such non-x86 native runners on Gitlab.

There:

$ clang --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)

If we don't use Travis-CI, then your patch is fine, but we
need a previous patch removing .travis.yml.

> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  configure | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/configure b/configure
> index 43d2470bb6..c41a3e5eef 100755
> --- a/configure
> +++ b/configure
> @@ -2050,12 +2050,12 @@ fi
>  cat > $TMPC << EOF
>  #if defined(__clang_major__) && defined(__clang_minor__)
>  # ifdef __apple_build_version__
> -#  if __clang_major__ < 5 || (__clang_major__ == 5 && __clang_minor__ < 1)
> -#   error You need at least XCode Clang v5.1 to compile QEMU
> +#  if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ < 2)
> +#   error You need at least XCode Clang v10.2 to compile QEMU
>  #  endif
>  # else
> -#  if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
> -#   error You need at least Clang v3.4 to compile QEMU
> +#  if __clang_major__ < 7 || (__clang_major__ == 7 && __clang_minor__ < 0)
> +#   error You need at least Clang v7.0 to compile QEMU
>  #  endif
>  # endif
>  #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
> @@ -2068,7 +2068,7 @@ cat > $TMPC << EOF
>  int main (void) { return 0; }
>  EOF
>  if ! compile_prog "" "" ; then
> -    error_exit "You need at least GCC v6.3 or Clang v3.4 (or XCode Clang 
> v5.1)"
> +    error_exit "You need at least GCC v6.3 or Clang v7.0 (or XCode Clang 
> v10.2)"
>  fi
>  
>  # Accumulate -Wfoo and -Wno-bar separately.
>