Re: [PULL v2 0/1] readthedoc theme patch

[Peter Maydell]

On Wed, 12 May 2021 at 17:02, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> On Wed, May 12, 2021 at 7:56 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
>> >> NetBSD now complains:
>> >>
>> >> Configuring 60-edk2-x86_64.json using configuration
>> >> Program qemu-keymap found: NO
>> >> Program sphinx-build found: YES
>> >> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build:
>> >> Configuration error:
>> >> There is a programable error in your configuration file:
>> >>
>> >> Traceback (most recent call last):
>> >>   File "conf.py", line 154, in <module>
>> >>     import sphinx_rtd_theme
>> >> ModuleNotFoundError: No module named 'sphinx_rtd_theme'
>> >>
>> >> During handling of the above exception, another exception occurred:
>> >>
>> >> Traceback (most recent call last):
>> >>   File "/usr/lib/python3/dist-packages/sphinx/config.py", line 157, in 
>> >> __init__
>> >>     execfile_(filename, config)
>> >>   File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line
>> >> 150, in execfile_
>> >>     exec_(code, _globals)
>> >>   File "conf.py", line 157, in <module>
>> >>     'The Sphinx \'sphinx_rtd_theme\' HTML theme was not found.\n'
>> >> sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme
>> >> was not found.
>> >>
>> >>
>> >>
>> >> Program python3 found: YES (/usr/bin/python3)
>> >> Program diff found: YES
>> >> Program dbus-daemon found: YES
>> >>
>> >>
>> >> as does freebsd and openbsd. Can we get the theme added to the VM
>> >> configs for those ?
>>
>> > What is used for the BSD configs? If it's tests/vm, I don't see readthedoc 
>> > being installed there, and vm-build-* should work (at least some work for 
>> > me, freebsd fails with ssh issue here)
>>
>> It's tests/vm.  The build doesn't fail, but the printing of the WARNING
>> is caught by my wrapper scripts (which grep for various warning/error
>> words to catch issues which don't trigger complete build failures).
>> Adding the theme to the configs would mean that we can continue to
>> test docs builds on those platforms.
>
>
> Didn't you install readthedoc manually there? I don't see those warnings.

No, I don't install anything manually on the BSD VM setups -- I just
use the tests/vm makefile magic to run a build-and-test.

thanks
-- PMM