Re: [RFC PATCH 10/11] target/ppc: created tcg-stub.c file

[Bruno Piazera Larsen]

On 12/05/2021 15:39, Richard Henderson wrote:

> On
>       5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
>       
> > +++ b/target/ppc/tcg-stub.c
> >         
> >         @@ -0,0 +1,33 @@
> >         
> >         +
> >         
> >         +#include "qemu/osdep.h"
> >         
> >       
>       
>       All files get copyright boilerplate.
>       
>     
    yeah, I didn't expect this file to stick around, though, as the last
    time we made a stub file, it ended up not being used, so I decided
    to go the quick route
>       
> > +#include "exec/hwaddr.h"
> >         
> >         +#include "cpu.h"
> >         
> >         +#include "hw/ppc/spapr.h"
> >         
> >         +
> >         
> >         +hwaddr ppc_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
> >         
> >         +{
> >         
> >         +    return 0;
> >         
> >         +}
> >         
> >       
>       
>       This is used by gdbstub.
>       
>       
>       If there's a way for kvm to convert a virtual address to a
>       physical address using the hardware, then use that.  I suspect
>       there is not.
>       
>       
>       Otherwise, you have to keep all of the mmu page table walking
>       stuff for kvm as well as tcg.  Which probably means that all of
>       the other stuff that you're stubbing out is used or usable as
>       well.
>       
>     
    ah, this probably means we'll need to compile mmu_helper.c too...
    that was something we were hoping to avoid, because of the sheer
    size. 
>       
>       
>       r~
>       
>

--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer