[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHO
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required |
|
Date: |
Thu, 13 May 2021 19:00:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Cc Alex & Thomas
On 5/13/21 6:38 PM, Philippe Mathieu-Daudé wrote:
> ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets.
> Move the variable assignment out of the block documented with
> "Uncomment the following lines to disable these optional devices".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> default-configs/devices/arm-softmmu.mak | 4 +++-
> default-configs/devices/riscv32-softmmu.mak | 4 +++-
> default-configs/devices/riscv64-softmmu.mak | 4 +++-
> 3 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/default-configs/devices/arm-softmmu.mak
> b/default-configs/devices/arm-softmmu.mak
> index 341d439de6f..2713e5e9eb7 100644
> --- a/default-configs/devices/arm-softmmu.mak
> +++ b/default-configs/devices/arm-softmmu.mak
> @@ -1,5 +1,8 @@
> # Default configuration for arm-softmmu
>
> +# TODO: semihosting is always required - move to default-configs/targets/
> +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
> +
> # TODO: ARM_V7M is currently always required - make this more flexible!
> CONFIG_ARM_V7M=y
>
> @@ -41,5 +44,4 @@ CONFIG_MICROBIT=y
> CONFIG_FSL_IMX25=y
> CONFIG_FSL_IMX7=y
> CONFIG_FSL_IMX6UL=y
> -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
> CONFIG_ALLWINNER_H3=y
> diff --git a/default-configs/devices/riscv32-softmmu.mak
> b/default-configs/devices/riscv32-softmmu.mak
> index 5c9ad2590ef..7219f9749ad 100644
> --- a/default-configs/devices/riscv32-softmmu.mak
> +++ b/default-configs/devices/riscv32-softmmu.mak
> @@ -1,9 +1,11 @@
> # Default configuration for riscv32-softmmu
>
> +# TODO: semihosting is always required - move to default-configs/targets/
> +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
> +
> # Uncomment the following lines to disable these optional devices:
> #
> #CONFIG_PCI_DEVICES=n
> -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
>
> # Boards:
> #
> diff --git a/default-configs/devices/riscv64-softmmu.mak
> b/default-configs/devices/riscv64-softmmu.mak
> index 8a92f0a2c74..1d1b8bb9f68 100644
> --- a/default-configs/devices/riscv64-softmmu.mak
> +++ b/default-configs/devices/riscv64-softmmu.mak
> @@ -1,9 +1,11 @@
> # Default configuration for riscv64-softmmu
>
> +# TODO: semihosting is always required - move to default-configs/targets/
> +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
> +
> # Uncomment the following lines to disable these optional devices:
> #
> #CONFIG_PCI_DEVICES=n
> -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
>
> # Boards:
> #
>
- [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, (continued)
- [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 05/10] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 04/10] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 07/10] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 08/10] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 09/10] default-configs/devices: Remove implicy SEMIHOSTING config, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required, Philippe Mathieu-Daudé, 2021/05/13
- Re: [PATCH 00/10] hw: Various Kconfig fixes, Paolo Bonzini, 2021/05/13