[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check
From: |
Thomas Huth |
Subject: |
[PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check |
Date: |
Fri, 14 May 2021 14:15:11 +0200 |
From: Peter Maydell <peter.maydell@linaro.org>
In rtc-test.c we know that s is non-NULL because qtest_start()
will return a non-NULL value, and we assume this when we
pass s to qtest_irq_intercept_in(). So we can drop the
initial assignment of NULL and the "if (s)" condition at
the end of the function.
Fixes: Coverity CID 1432353
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210503165525.26221-3-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/rtc-test.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c
index 402ce2c609..8126ab1bdb 100644
--- a/tests/qtest/rtc-test.c
+++ b/tests/qtest/rtc-test.c
@@ -686,7 +686,7 @@ static void periodic_timer(void)
int main(int argc, char **argv)
{
- QTestState *s = NULL;
+ QTestState *s;
int ret;
g_test_init(&argc, &argv, NULL);
@@ -712,9 +712,7 @@ int main(int argc, char **argv)
ret = g_test_run();
- if (s) {
- qtest_quit(s);
- }
+ qtest_quit(s);
return ret;
}
--
2.27.0
- [PULL 01/20] tests/docker/dockerfiles: Add ccache to containers where it was missing, (continued)
- [PULL 01/20] tests/docker/dockerfiles: Add ccache to containers where it was missing, Thomas Huth, 2021/05/14
- [PULL 03/20] gitlab-ci: Replace YAML anchors by extends (native_build_job), Thomas Huth, 2021/05/14
- [PULL 04/20] gitlab-ci: Replace YAML anchors by extends (native_test_job), Thomas Huth, 2021/05/14
- [PULL 05/20] libqos/qgraph: fix "UNAVAILBLE" typo, Thomas Huth, 2021/05/14
- [PULL 07/20] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm, Thomas Huth, 2021/05/14
- [PULL 06/20] docs/devel/qgraph: add troubleshooting information, Thomas Huth, 2021/05/14
- [PULL 10/20] tests/qtest/npcm7xx_pwm-test.c: Avoid g_assert_true() for non-test assertions, Thomas Huth, 2021/05/14
- [PULL 11/20] tests/migration-test: Fix "true" vs true, Thomas Huth, 2021/05/14
- [PULL 09/20] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic, Thomas Huth, 2021/05/14
- [PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc., Thomas Huth, 2021/05/14
- [PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check,
Thomas Huth <=
- [PULL 17/20] configure: Poison all current target-specific #defines, Thomas Huth, 2021/05/14
- [PULL 14/20] tests: Avoid side effects inside g_assert() arguments, Thomas Huth, 2021/05/14
- [PULL 15/20] include/sysemu: Poison all accelerator CONFIG switches in common code, Thomas Huth, 2021/05/14
- [PULL 16/20] migration: Move populate_vfio_info() into a separate file, Thomas Huth, 2021/05/14
- [PULL 12/20] tests/qtest/tpm-util.c: Free memory with correct free function, Thomas Huth, 2021/05/14
- [PULL 19/20] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang, Thomas Huth, 2021/05/14
- [PULL 18/20] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths, Thomas Huth, 2021/05/14
- [PULL 20/20] cirrus.yml: Fix the MSYS2 task, Thomas Huth, 2021/05/14