Re: [RFC PATCH 2/9] replace machine phase_check with machine_is

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initiali

From:	Paolo Bonzini
Subject:	Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls
Date:	Fri, 14 May 2021 23:14:23 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 14/05/21 15:13, Mirela Grujic wrote:

However, if you believe it should rather be just renamed I can do so.

I am just not sure it's such an advantage to replace phase_check withseparate functions. The rename is a constraint of QAPI, so we have tolive with the long names.


Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

[RFC PATCH 0/9] Initial support for machine creation via QMP, Mirela Grujic, 2021/05/13
- [RFC PATCH 1/9] vl: Allow finer control in advancing machine through phases, Mirela Grujic, 2021/05/13
- [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls, Mirela Grujic, 2021/05/13
  - Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls, Paolo Bonzini, 2021/05/13
    - Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls, Mirela Grujic, 2021/05/14
    - Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls, Paolo Bonzini <=
- [RFC PATCH 3/9] rename MachineInitPhase enumeration constants, Mirela Grujic, 2021/05/13
- [RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command, Mirela Grujic, 2021/05/13
  - Re: [RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command, Paolo Bonzini, 2021/05/13
    - Re: [RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command, Daniel P . Berrangé, 2021/05/19
- [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command, Mirela Grujic, 2021/05/13
- [RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command, Mirela Grujic, 2021/05/13
  - Re: [RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command, Kevin Wolf, 2021/05/19
- [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability, Mirela Grujic, 2021/05/13
  - Re: [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability, Paolo Bonzini, 2021/05/13
    - Re: [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability, Mirela Grujic, 2021/05/14

Prev by Date: Re: [PATCH 5/6] co-shared-resource: protect with a mutex
Next by Date: Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx
Previous by thread: Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls
Next by thread: [RFC PATCH 3/9] rename MachineInitPhase enumeration constants
Index(es):
- Date
- Thread