[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typ
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode |
Date: |
Sat, 15 May 2021 11:10:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 1:57 AM, Richard Henderson wrote:
> We will shortly be interested in distinguishing pointers
> from integers in the helper's declaration, as well as a
> true void return. We currently have two parallel 1 bit
> fields; merge them and expand to a 3 bit field.
>
> Our current maximum is 7 helper arguments, plus the return
> makes 8 * 3 = 24 bits used within the uint32_t typemask.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/helper-head.h | 37 +++++--------------
> include/exec/helper-tcg.h | 34 ++++++++---------
> target/hppa/helper.h | 3 --
> target/i386/ops_sse_header.h | 3 --
> target/m68k/helper.h | 1 -
> target/ppc/helper.h | 3 --
> tcg/tcg.c | 71 +++++++++++++++++++++---------------
> 7 files changed, 67 insertions(+), 85 deletions(-)
Nice. I've been looking for a definition name for the heavily
used magic '3', but using such definitions doesn't really
help in the code review, so we are better without it.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v6 00/26] TCI fixes and cleanups, Richard Henderson, 2021/05/02
- [PATCH v6 03/26] accel/tcg/plugin-gen: Drop inline markers, Richard Henderson, 2021/05/02
- [PATCH v6 02/26] tcg: Add tcg_call_flags, Richard Henderson, 2021/05/02
- [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode, Richard Henderson, 2021/05/02
- Re: [PATCH v6 01/26] tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode,
Philippe Mathieu-Daudé <=
- [PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb, Richard Henderson, 2021/05/02
- [PATCH v6 06/26] tcg: Store the TCGHelperInfo in the TCGOp for call, Richard Henderson, 2021/05/02
- [PATCH v6 05/26] accel/tcg: Add tcg call flags to plugins helpers, Richard Henderson, 2021/05/02
- [PATCH v6 07/26] tcg: Add tcg_call_func, Richard Henderson, 2021/05/02