[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os
From: |
John Snow |
Subject: |
[PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) |
Date: |
Mon, 17 May 2021 14:48:04 -0400 |
One less file resource to manage, and it helps quiet some pylint >=
2.8.0 warnings about not using a with-context manager for the open call.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
python/qemu/machine.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 6e44bda337e..41f51bd27d0 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -223,9 +223,8 @@ def send_fd_scm(self, fd: Optional[int] = None,
assert fd is not None
fd_param.append(str(fd))
- devnull = open(os.path.devnull, 'rb')
proc = subprocess.Popen(
- fd_param, stdin=devnull, stdout=subprocess.PIPE,
+ fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, close_fds=False
)
output = proc.communicate()[0]
@@ -393,7 +392,6 @@ def _launch(self) -> None:
"""
Launch the VM and establish a QMP connection
"""
- devnull = open(os.path.devnull, 'rb')
self._pre_launch()
self._qemu_full_args = tuple(
chain(self._wrapper,
@@ -403,7 +401,7 @@ def _launch(self) -> None:
)
LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
self._popen = subprocess.Popen(self._qemu_full_args,
- stdin=devnull,
+ stdin=subprocess.DEVNULL,
stdout=self._qemu_log_file,
stderr=subprocess.STDOUT,
shell=False,
--
2.30.2
- [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/17
- [PATCH v2 1/6] python/console_socket: avoid one-letter variable, John Snow, 2021/05/17
- [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull),
John Snow <=
- [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen, John Snow, 2021/05/17
- [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/17
- [PATCH v2 6/6] python/machine: disable warning for Popen in _launch(), John Snow, 2021/05/17
- [PATCH v2 4/6] python/console_socket: Add a pylint ignore, John Snow, 2021/05/17
- Re: [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/18