[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.
From: |
John Snow |
Subject: |
[PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen |
Date: |
Mon, 17 May 2021 14:48:05 -0400 |
use run() instead of Popen() -- to assert to pylint that we are not
forgetting to close a long-running program.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine.py | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 41f51bd27d0..2e55e2c8bd8 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -223,13 +223,16 @@ def send_fd_scm(self, fd: Optional[int] = None,
assert fd is not None
fd_param.append(str(fd))
- proc = subprocess.Popen(
- fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
- stderr=subprocess.STDOUT, close_fds=False
+ proc = subprocess.run(
+ fd_param,
+ stdin=subprocess.DEVNULL,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ check=False,
+ close_fds=False,
)
- output = proc.communicate()[0]
- if output:
- LOG.debug(output)
+ if proc.stdout:
+ LOG.debug(proc.stdout)
return proc.returncode
--
2.30.2
- [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/17
- [PATCH v2 1/6] python/console_socket: avoid one-letter variable, John Snow, 2021/05/17
- [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull), John Snow, 2021/05/17
- [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen,
John Snow <=
- [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/17
- [PATCH v2 6/6] python/machine: disable warning for Popen in _launch(), John Snow, 2021/05/17
- [PATCH v2 4/6] python/console_socket: Add a pylint ignore, John Snow, 2021/05/17
- Re: [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/18