[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size |
|
Date: |
Tue, 18 May 2021 09:03:44 +0200 |
On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote:
> Sorry I do not state the background clearly.
>
> Page size is 16K on my MIPS machine, and it supports running
> guest OS in kvm mode and qxl vga card can used for VM.
Ok. Please add that to the commit message.
Also there is no need to rewrite the function and drop the
BUILD_BUG_ON(). Just using "return QEMU_ALIGN_UP(QXL_ROM_SZ, pagesize)"
should work fine.
Is the host page size fixed on mips?
take care,
Gerd