[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] remove qemu-options* from root directory
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] remove qemu-options* from root directory |
Date: |
Tue, 18 May 2021 10:54:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> These headers are also included from softmmu/vl.c, so they should be
> in include/. Removing qemu-options-wrapper.h, since elsewhere
> we include "template" headers directly and #define the parameters in
> the including file, and move qemu-options.h to include/.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qemu-options.h => include/qemu/qemu-options.h | 9 ++++-
> os-posix.c | 2 +-
> os-win32.c | 1 -
> qemu-options-wrapper.h | 40 -------------------
> qemu-options.hx | 4 ++
> softmmu/vl.c | 24 ++++++++---
> 6 files changed, 31 insertions(+), 49 deletions(-)
> rename qemu-options.h => include/qemu/qemu-options.h (88%)
> delete mode 100644 qemu-options-wrapper.h
Much nicer without qemu-options-wrapper.h.
I'd be tempted to rename qemu-options.def while there (what's .def?),
but that's up to you.
Reviewed-by: Markus Armbruster <armbru@redhat.com>