[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough |
Date: |
Tue, 18 May 2021 10:56:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/18/21 10:41 AM, Paolo Bonzini wrote:
> I could not reconstruct the origin of the $(($(nproc) + 1)) idiom,
I guess it is the historical way make would aggressively use
the most compute power it could? Then later this bad habit impact
was reduced by the -l option to keep make under some system load
value.
> but I suspect it was there only to have a sensible result when nproc
> or getconf do not exist. This can be achieved also with an "||".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
BTW more candidates:
.gitlab-ci.d/edk2.yml:49: - export JOBS=$(($(getconf _NPROCESSORS_ONLN)
+ 1))
.gitlab-ci.d/opensbi.yml:52: - export JOBS=$(($(getconf
_NPROCESSORS_ONLN) + 1))
.travis.yml:93: - export JOBS=3
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PATCH 3/3] ci: add -j to all "make" jobs, Paolo Bonzini, 2021/05/18
[PATCH 1/3] cirrus-ci: test installation, Paolo Bonzini, 2021/05/18
Re: [PATCH 0/3] Small CI improvements, Alex Bennée, 2021/05/19