[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes
From: |
Vivek Goyal |
Subject: |
[PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes |
Date: |
Tue, 18 May 2021 17:35:34 -0400 |
There are places where we need to skip few bytes from front of the iovec
array. We have our own custom code for that. Looks like iov_discard_front()
can do same thing. So use that helper instead.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
tools/virtiofsd/fuse_virtio.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 28e2974d1a..09674f2e90 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -389,23 +389,15 @@ int virtio_send_data_iov(struct fuse_session *se, struct
fuse_chan *ch,
memcpy(in_sg_cpy, in_sg, sizeof(struct iovec) * in_num);
/* These get updated as we skip */
struct iovec *in_sg_ptr = in_sg_cpy;
- int in_sg_cpy_count = in_num;
+ unsigned int in_sg_cpy_count = in_num;
/* skip over parts of in_sg that contained the header iov */
size_t skip_size = iov_len;
size_t in_sg_left = 0;
do {
- while (skip_size != 0 && in_sg_cpy_count) {
- if (skip_size >= in_sg_ptr[0].iov_len) {
- skip_size -= in_sg_ptr[0].iov_len;
- in_sg_ptr++;
- in_sg_cpy_count--;
- } else {
- in_sg_ptr[0].iov_len -= skip_size;
- in_sg_ptr[0].iov_base += skip_size;
- break;
- }
+ if (skip_size != 0) {
+ iov_discard_front(&in_sg_ptr, &in_sg_cpy_count, skip_size);
}
int i;
--
2.25.4
- [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Vivek Goyal, 2021/05/18
- [PATCH v2 4/7] virtiofsd: get rid of in_sg_left variable, Vivek Goyal, 2021/05/18
- [PATCH v2 6/7] virtiofsd: Check EOF before short read, Vivek Goyal, 2021/05/18
- [PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read, Vivek Goyal, 2021/05/18
- [PATCH v2 7/7] virtiofsd: Set req->reply_sent right after sending reply, Vivek Goyal, 2021/05/18
- [PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes,
Vivek Goyal <=
- [PATCH v2 1/7] virtiofsd: Check for EINTR in preadv() and retry, Vivek Goyal, 2021/05/18
- [PATCH v2 5/7] virtiofsd: Simplify skip byte logic, Vivek Goyal, 2021/05/18
- Re: [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Dr. David Alan Gilbert, 2021/05/25