qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] target/ppc: reduce usage of fpscr_set_rounding_mode


From: Richard Henderson
Subject: Re: [PATCH v2 3/7] target/ppc: reduce usage of fpscr_set_rounding_mode
Date: Wed, 19 May 2021 10:56:05 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/18/21 10:05 AM, Bruno Larsen (billionai) wrote:
+    int old_rounding_mode = get_float_rounding_mode(&env->fp_status);

FloatRoundMode is a better type for the variable.

@@ -3136,8 +3136,10 @@ void helper_##op(CPUPPCState *env, ppc_vsr_t *xt, 
ppc_vsr_t *xb)       \
 {                                                                      \
     ppc_vsr_t t = *xt;                                                 \
     int i;                                                             \
+    int curr_rounding_mode;                                            \

Likewise.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]