[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 08/25] qemu/bswap: Use ST_CONVERT() macro to emit 16-bit
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 08/25] qemu/bswap: Use ST_CONVERT() macro to emit 16-bit load/store functions |
Date: |
Wed, 19 May 2021 19:30:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/18/21 10:08 PM, Peter Maydell wrote:
> On Tue, 18 May 2021 at 19:37, Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> include/qemu/bswap.h | 17 ++---------------
>> 1 file changed, 2 insertions(+), 15 deletions(-)
>>
>> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
>> index 86f5ded6acf..4e2bd2e97ee 100644
>> --- a/include/qemu/bswap.h
>> +++ b/include/qemu/bswap.h
>> @@ -350,11 +350,6 @@ static inline int ldsw_he_p(const void *ptr)
>> return r;
>> }
>>
>> -static inline void stw_he_p(void *ptr, uint16_t v)
>> -{
>> - __builtin_memcpy(ptr, &v, sizeof(v));
>> -}
>> -
>> static inline int ldl_he_p(const void *ptr)
>> {
>> int32_t r;
>> @@ -399,11 +394,6 @@ static inline uint64_t ldq_le_p(const void *ptr)
>> return le_bswap(ldq_he_p(ptr), 64);
>> }
>>
>> -static inline void stw_le_p(void *ptr, uint16_t v)
>> -{
>> - stw_he_p(ptr, le_bswap(v, 16));
>> -}
>> -
>> static inline void stl_le_p(void *ptr, uint32_t v)
>> {
>> stl_he_p(ptr, le_bswap(v, 32));
>> @@ -434,11 +424,6 @@ static inline uint64_t ldq_be_p(const void *ptr)
>> return be_bswap(ldq_he_p(ptr), 64);
>> }
>>
>> -static inline void stw_be_p(void *ptr, uint16_t v)
>> -{
>> - stw_he_p(ptr, be_bswap(v, 16));
>> -}
>> -
>> static inline void stl_be_p(void *ptr, uint32_t v)
>> {
>> stl_he_p(ptr, be_bswap(v, 32));
>> @@ -466,6 +451,8 @@ static inline void st ## size ## _ ## endian ## _p(void
>> *ptr, vtype v)\
>> ST_CONVERT_END(le, bits, vtype, size)\
>> ST_CONVERT_END(be, bits, vtype, size)
>>
>> +ST_CONVERT(16, uint16_t, w)
>> +
>
> Where we have a macro that emits a bunch of function declarations,
> can we also add a comment that (a) documents the functions and
> (b) explicitly lists the name of every generated function?
> The latter in particular is really helpful for people who are
> trying to find function declarations/definitions with 'grep'.
> The comment above the definition and use of the CPU_CONVERT
> macro in bswap.h is an example.
For (a) I think the current comment is still valid:
/*
* the generic syntax is:
*
* load: ld{type}{sign}{size}_{endian}_p(ptr)
*
* store: st{type}{size}_{endian}_p(ptr, val)
...
For (b), certainly, I'll add that list.
Thanks,
Phil.
- [RFC PATCH 00/25] exec: Add load/store API for aligned pointers, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 01/25] exec/memory_ldst_cached: Sort declarations, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 03/25] exec/memory_ldst: Use correct type sizes, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 02/25] exec/memory_ldst_phys: Sort declarations, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 04/25] exec/memory_ldst_phys: Use correct type sizes, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 05/25] exec/memory_ldst_cached: Use correct type size, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 06/25] exec/memory: Use correct type size, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 08/25] qemu/bswap: Use ST_CONVERT() macro to emit 16-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 07/25] qemu/bswap: Introduce ST_CONVERT() macro, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 09/25] qemu/bswap: Introduce LD_CONVERT() macro, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 10/25] qemu/bswap: Use LD_CONVERT macro to emit 16-bit signed load/store code, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 11/25] qemu/bswap: Use LD_CONVERT macro to emit 16-bit unsigned load/store code, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 12/25] qemu/bswap: Use LDST_CONVERT macro to emit 32-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 13/25] qemu/bswap: Use LDST_CONVERT macro to emit 64-bit load/store functions, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 14/25] qemu/bswap: Introduce load/store for aligned pointer, Philippe Mathieu-Daudé, 2021/05/18