[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/3] hw/core/loader: Move 'write_rom' trace event earlier
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 2/3] hw/core/loader: Move 'write_rom' trace event earlier |
Date: |
Thu, 20 May 2021 07:15:41 +0200 |
It is more useful to trace the event which will happen,
rather than missing an event that failed. So move the
'write_rom' trace event earlier.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/core/loader.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index 5b34869a541..b3c4a654b45 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -1142,6 +1142,7 @@ static void rom_reset(void *unused)
if (rom->data == NULL) {
continue;
}
+ trace_loader_write_rom(rom->name, rom->addr, rom->datasize,
rom->isrom);
if (rom->mr) {
void *host = memory_region_get_ram_ptr(rom->mr);
memcpy(host, rom->data, rom->datasize);
@@ -1160,8 +1161,6 @@ static void rom_reset(void *unused)
* CPU definitely fetches its instructions from the just written data.
*/
cpu_flush_icache_range(rom->addr, rom->datasize);
-
- trace_loader_write_rom(rom->name, rom->addr, rom->datasize,
rom->isrom);
}
}
--
2.26.3