[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/26] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
From: |
Paolo Bonzini |
Subject: |
[PULL 04/26] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' |
Date: |
Thu, 20 May 2021 10:22:35 +0200 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Per the kconfig.rst:
A device should be listed [...] ``imply`` if (depending on
the QEMU command line) the board may or may not be started
without it.
This is the case with the NVDIMM device, so use the 'imply'
weak reverse dependency to select the symbol.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210511155354.3069141-2-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
default-configs/devices/ppc64-softmmu.mak | 1 -
hw/arm/Kconfig | 1 +
hw/i386/Kconfig | 1 +
hw/mem/Kconfig | 2 --
hw/ppc/Kconfig | 1 +
5 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/default-configs/devices/ppc64-softmmu.mak
b/default-configs/devices/ppc64-softmmu.mak
index ae0841fa3a..cca52665d9 100644
--- a/default-configs/devices/ppc64-softmmu.mak
+++ b/default-configs/devices/ppc64-softmmu.mak
@@ -8,4 +8,3 @@ CONFIG_POWERNV=y
# For pSeries
CONFIG_PSERIES=y
-CONFIG_NVDIMM=y
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index b887f6a5b1..67723d9ea6 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -6,6 +6,7 @@ config ARM_VIRT
imply VFIO_PLATFORM
imply VFIO_XGMAC
imply TPM_TIS_SYSBUS
+ imply NVDIMM
select ARM_GIC
select ACPI
select ARM_SMMUV3
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 7f91f30877..66838fa397 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -23,6 +23,7 @@ config PC
imply TPM_TIS_ISA
imply VGA_PCI
imply VIRTIO_VGA
+ imply NVDIMM
select FDC
select I8259
select I8254
diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
index a0ef2cf648..8b19fdc49f 100644
--- a/hw/mem/Kconfig
+++ b/hw/mem/Kconfig
@@ -7,6 +7,4 @@ config MEM_DEVICE
config NVDIMM
bool
- default y
- depends on (PC || PSERIES || ARM_VIRT)
select MEM_DEVICE
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index e51e0e5e5a..66e0b15d9e 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -3,6 +3,7 @@ config PSERIES
imply PCI_DEVICES
imply TEST_DEVICES
imply VIRTIO_VGA
+ imply NVDIMM
select DIMM
select PCI
select SPAPR_VSCSI
--
2.31.1
- [PULL 00/26] Misc patches for 2021-05-20, Paolo Bonzini, 2021/05/20
- [PULL 03/26] configure: simplify assignment to GIT_SUBMODULES, Paolo Bonzini, 2021/05/20
- [PULL 01/26] configure: Only clone softfloat-3 repositories if TCG is enabled, Paolo Bonzini, 2021/05/20
- [PULL 14/26] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Paolo Bonzini, 2021/05/20
- [PULL 04/26] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on',
Paolo Bonzini <=
- [PULL 12/26] KVM: Create the KVMSlot dirty bitmap on flag changes, Paolo Bonzini, 2021/05/20
- [PULL 02/26] configure: check for submodules if --with-git-submodules=ignore, Paolo Bonzini, 2021/05/20
- [PULL 07/26] object: add more commands to preconfig mode, Paolo Bonzini, 2021/05/20
- [PULL 05/26] i386/cpu: Expose AVX_VNNI instruction to guest, Paolo Bonzini, 2021/05/20
- [PULL 21/26] meson: Set implicit_include_directories to false, Paolo Bonzini, 2021/05/20
- [PULL 20/26] tests/qtest/fuzz: Fix build failure, Paolo Bonzini, 2021/05/20
- [PULL 08/26] qtest: add a QOM object for qtest, Paolo Bonzini, 2021/05/20
- [PULL 15/26] KVM: Simplify dirty log sync in kvm_set_phys_mem, Paolo Bonzini, 2021/05/20
- [PULL 19/26] KVM: Dirty ring support, Paolo Bonzini, 2021/05/20
- [PULL 09/26] KVM: do not allow setting properties at runtime, Paolo Bonzini, 2021/05/20