Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections

qemu-devel

From:	John Snow
Subject:	Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections
Date:	Fri, 21 May 2021 11:55:29 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/21/21 1:35 AM, Markus Armbruster wrote:

Does not fire for qga/qapi-schema.json.  Can you help?


Odd.

I did:

if self._section:
    ...
else:
    raise QAPIWhicheverErrorItWas(...)

and then did a full build and found it to fail on QGA stuff. You mayneed --enable-docs to make it happen.


It later failed on test cases, too.

--js

Current Thread

[Next in Thread]

[PATCH 0/6] qapi: static typing conversion, pt5b, John Snow, 2021/05/19
- [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections, John Snow, 2021/05/19
  - Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections, Markus Armbruster, 2021/05/20
    - Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections, John Snow, 2021/05/20
    - Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections, Markus Armbruster, 2021/05/21
    - Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections, John Snow <=
- [PATCH 4/6] qapi/parser.py: enable mypy checks, John Snow, 2021/05/19
- [PATCH 1/6] qapi/parser.py: remove unused check_args_section arguments, John Snow, 2021/05/19
  - Re: [PATCH 1/6] qapi/parser.py: remove unused check_args_section arguments, Markus Armbruster, 2021/05/20
- [PATCH 5/6] qapi/parser.py: Silence too-few-public-methods warning, John Snow, 2021/05/19
- [PATCH 6/6] qapi/parser.py: enable pylint checks, John Snow, 2021/05/19
- [PATCH 3/6] qapi/parser.py: add type hint annotations (QAPIDoc), John Snow, 2021/05/19
  - Re: [PATCH 3/6] qapi/parser.py: add type hint annotations (QAPIDoc), Markus Armbruster, 2021/05/20
    - Re: [PATCH 3/6] qapi/parser.py: add type hint annotations (QAPIDoc), John Snow, 2021/05/20
    - Re: [PATCH 3/6] qapi/parser.py: add type hint annotations (QAPIDoc), Markus Armbruster, 2021/05/21