[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1
From: |
David Gibson |
Subject: |
Re: [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1 |
Date: |
Mon, 24 May 2021 12:36:28 +1000 |
On Fri, May 21, 2021 at 05:17:51PM -0300, Bruno Larsen (billionai) wrote:
> Changed how the function ppc_store_sdr1, from error_report(...) to
> qemu_log_mask(LOG_GUEST_ERROR, ...).
>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/cpu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c
> index d957d1a687..9cf3288b7a 100644
> --- a/target/ppc/cpu.c
> +++ b/target/ppc/cpu.c
> @@ -77,13 +77,13 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong value)
> target_ulong htabsize = value & SDR_64_HTABSIZE;
>
> if (value & ~sdr_mask) {
> - error_report("Invalid bits 0x"TARGET_FMT_lx" set in SDR1",
> - value & ~sdr_mask);
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid bits 0x"TARGET_FMT_lx
> + " set in SDR1", value & ~sdr_mask);
> value &= sdr_mask;
> }
> if (htabsize > 28) {
> - error_report("Invalid HTABSIZE 0x" TARGET_FMT_lx" stored in
> SDR1",
> - htabsize);
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid HTABSIZE 0x"
> TARGET_FMT_lx
> + " stored in SDR1", htabsize);
> return;
> }
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v3 0/9] target/ppc: add support to disable-tcg, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1, Bruno Larsen (billionai), 2021/05/21
- Re: [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1,
David Gibson <=
- [PATCH v3 2/9] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h, Bruno Larsen (billionai), 2021/05/21